Ticket #67 (closed defect: fixed)

Opened 4 months ago

Last modified 2 months ago

setters method in capi file

Reported by: MartinVales Owned by: hobu
Priority: major Milestone: 1.0
Component: C API Version:
Keywords: Cc: mloskot
LAS Format Version: Not Applicable

Description (last modified by hobu) (diff)

I don´t see in the CAPI the setter of this methods. Perhaps it´s not secure??

LASHeader_SetFileSourceId
LASHeader_SetDataOffset
LASHeader_SetDataRecordLength
LASHeader_SetRecordsCount
LASHeader_SetProjectId
LASHeader_SetReserved
LASHeader_SetHeaderSize
LASHeader_SetDataRecordLength

Change History

Changed 4 months ago by hobu

  • description modified (diff)

Changed 4 months ago by hobu

  • cc mloskot added

1) LASHeader_SetFileSourceId LASHeader_SetReserved

  • I think this missing from the C API is an oversight

2) LASHeader_SetDataOffset LASHeader_SetDataRecordLength

  • libLAS handles these internally. Depending on the DataFormatId? you give and the MinorVersion?, libLAS will set the appropriate value for these two items. Can you possibly give a reason why an external caller would want to manipulate these values?

3) LASHeader_SetRecordsCount LASHeader_SetHeaderSize

  • you *maybe* could make a case for having these be publicly manipulated, but libLAS currently will change these values for you without warning and expects to change them when it needs.

4) LASHeader_SetProjectId

  • you can only create a ProjectID using the LASGUIDH interface, and GetProjectID is going to just return you the character representation of the LASGUIDH. I would accept a patch that makes these methods orthogonal, or a patch that removes it as it is redundant now that we have the LASGUIDH interface.

Changed 4 months ago by hobu

  • version svn-trunk deleted
  • milestone set to 1.0

Changed 2 months ago by hobu

  • status changed from new to closed
  • resolution set to fixed

Numbers 1 and 4 are done in r875.

Note: See TracTickets for help on using tickets.