Stack corruption in las2las

[mloskot]

I've experienced stack corruption in the las2las.c program around variable surviving_number_of_points_by_return.

In file las2las.c:354 following line does unsafe calculation of index:

surviving_number_of_points_by_return[LASPoint_GetReturnNumber(p)-1]++;

When LASPoint_GetReturnNumber(p) returns 0 then index evaluates to -1, equivalent of *(ptr - 1). Now, if surviving_number_of_points_by_return points to first element, then index -1 is out of range and applied operator ++ causes the memory corruption.

[hobu]

Fixed in r782