Ticket #55 (closed defect: fixed)

Opened 13 months ago

Last modified 13 months ago

Redundant exit() calls in las2las

Reported by: mloskot Owned by: hobu
Priority: minor Milestone:
Component: Utilities Version: svn-trunk
Keywords: las2las Cc:
LAS Format Version: Not Applicable

Description

In the las2las.c, following pattern can be observed:

...
usage();
exit(0);

later in the code:

...
usage();
exit(1);

The exit() calls are inconsistent and redundant because usage() calls exit(0). I'd propose to remove exit(0) from usage() and call it on request after usage, with appropriate return code for particular context (error or success).

Change History

Changed 13 months ago by hobu

  • status changed from new to closed
  • resolution set to fixed

removed in r779. Fixed in the other utilitiees in r780

Note: See TracTickets for help on using tickets.