Memory leak from LASWriter / lasspatialreference assignment operator=

[mrosen]

The patch below will fix a leak that occurs the first time a LAS Writer flushes its LASHeader. The magnitude of this leak seemed to be about 250Kb (??) per header.

m_tiff and g_tiff (below) are initially assigned during LASSpatialReference::SetGTIF() which is called whenever we call LASWriter_Create()

Without this patch, the first time we call LASWriter_WriteHeader, it calls LASSpatialReference::operator=, which sets these pointers to zero without cleaning up the memory thus causing the memory leak/s.

=======================

diff -r 23b3eb84dbd4 xt_lib_liblas/src/las-1.2/src/lasspatialreference.cpp
--- a/xt_lib_liblas/src/las-1.2/src/lasspatialreference.cpp	Sun Mar 22 18:19:05 2009 -0700
+++ b/xt_lib_liblas/src/las-1.2/src/lasspatialreference.cpp	Mon Aug 24 13:35:35 2009 -0700
@@ -58,8 +58,6 @@
 {
     if (&rhs != this)
     {
-        m_tiff = 0;
-        m_gtiff = 0;        
         SetVLRs(rhs.GetVLRs());
         GetGTIF();
     }

We found this while testing an application that did batch writing of LAS files.

[hobu]

fixed in r1342 and backported in r1343. Thanks for the report!