Changeset 959

Timestamp:

11/06/08 10:48:32 (2 months ago)

Author:

mloskot

Message:

liblas::LASPoint: fixed incorrect logical-or where logical-and is expected (Ticket #84).

Files:

• trunk/src/laspoint.cpp (modified) (2 diffs)

trunk/src/laspoint.cpp

@@ -144 +144 @@
 bool LASPoint::equal(LASPoint const& other) const
 {
-    double const epsilon = std::numeric_limits<double>::epsilon(); 
+    // TODO - mloskot: Default epsilon is too small.
+    //                 Is 0.00001 good as tolerance or too wide?
+    //double const epsilon = std::numeric_limits<double>::epsilon(); 
+    double const epsilon = 0.00001;
 
     double const dx = m_coords[0] - other.m_coords[0];
@@ -152 +155 @@
     // TODO: Should we compare other data members, besides the coordinates?
 
-    if (((dx <= epsilon) && (dx >= -epsilon ))
-        || ((dy <= epsilon) && (dy >= -epsilon ))
-        || ((dz <= epsilon) && (dz >= -epsilon )))
+    if (((dx <= epsilon) && (dx >= -epsilon))
+        && ((dy <= epsilon) && (dy >= -epsilon))
+        && ((dz <= epsilon) && (dz >= -epsilon)))
     {
         return true;